Re: Reduce the memcpy call from SearchCatCache

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Atsushi Ogawa <a_ogawa(at)hi-ho(dot)ne(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Reduce the memcpy call from SearchCatCache
Date: 2009-07-06 19:38:30
Message-ID: 20298.1246909110@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Atsushi Ogawa <a_ogawa(at)hi-ho(dot)ne(dot)jp> writes:
> Attached patch is reduce the memcpy calls from SearchCatCache
> and SearchCatCacheList. This patch directly uses cache->cc_skey
> in looking for hash table.

How much did you test this patch? I'm fairly sure it will break things.
There are cases where cache lookups happen recursively.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2009-07-06 19:40:41 Small foreign key error message improvement
Previous Message David E. Wheeler 2009-07-06 19:37:16 Maintenance Policy?