Re: ShmemAlloc() alignment patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Martijn van Oosterhout <kleptog(at)svana(dot)org>, Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: ShmemAlloc() alignment patch
Date: 2006-07-14 15:18:11
Message-ID: 20202.1152890291@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
>>> How can ShmemBase not be aligned? Surely it's page-aligned?

> Should we add an assert?

No, because even if it's not page-aligned, there's no correctness issue
here. (Besides, how would you know what the page size is on any given
platform?)

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Florian G. Pflug 2006-07-14 15:20:15 Forcing wal rotation
Previous Message Bruce Momjian 2006-07-14 14:59:00 pgsql: Have find_static skip main() functions.