From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Ahsan Hadi <ahsan(dot)hadi(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: more ALTER .. DEPENDS ON EXTENSION fixes |
Date: | 2020-04-09 18:38:37 |
Message-ID: | 20200409183837.GA17769@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2020-Mar-11, Tom Lane wrote:
> > thanks for it) to backbranches or just to master. It seems legitimate
> > to see it as a feature addition, but OTOH the overall feature is not
> > complete without it ...
>
> 0003 is the command addition to allow removing such a dependency,
> right? Given the lack of field demand I see no reason to risk
> adding it to the back branches.
Yeah, okay.
I hereby request permission to push this patch past the feature freeze
date; it's a very small one that completes an existing feature (rather
than a complete new feature in itself), and it's not intrusive nor
likely to break anything.
> BTW, I did not like the syntax too much. "NO DEPENDS ON EXTENSION"
> doesn't seem like good English. "NOT DEPENDS ON EXTENSION" is hardly
> any better. The real problem with both is that an ALTER action should
> be, well, an action. A grammar stickler would say that it should be
> "ALTER thing DROP DEPENDENCY ON EXTENSION ext", but perhaps we could
> get away with "ALTER thing DROP DEPENDS ON EXTENSION ext" to avoid
> adding a new keyword. By that logic the original command should have
> been "ALTER thing ADD DEPENDS ON EXTENSION ext", but I suppose it's
> too late for that.
I will be submitting a version with these changes shortly.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Janes | 2020-04-09 18:39:41 | Re: BUG #16345: ts_headline does not find phrase matches correctly |
Previous Message | Tim Bishop | 2020-04-09 18:36:26 | Re: debian bugrept involving fast default crash in pg11.7 |