Re: Don't try fetching future segment of a TLI.

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: masao(dot)fujii(at)oss(dot)nttdata(dot)com
Cc: psuderevsky(at)gmail(dot)com, david(at)pgmasters(dot)net, pgsql-hackers(at)lists(dot)postgresql(dot)org, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: Don't try fetching future segment of a TLI.
Date: 2020-04-07 01:29:09
Message-ID: 20200407.102909.709448322643210522.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Thank you for picking this up.

At Tue, 7 Apr 2020 02:43:02 +0900, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote in
> On 2020/03/19 22:22, Pavel Suderevsky wrote:
> > Hi,
> > I've tested patch provided by Kyotaro and do confirm it fixes the
> > issue.
>
> The patch looks good to me. Attached is the updated version of the
> patch.
> I updated only comments.

+ * The logfile segment that doesn't belong to the timeline is
+ * older or newer than the segment that the timeline started or
+ * eneded at, respectively. It's sufficient to check only the

s/eneded/ended/ ?

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Fujii Masao 2020-04-07 03:15:00 Re: Don't try fetching future segment of a TLI.
Previous Message Tom Lane 2020-04-06 19:08:49 Re: DROP OWNED CASCADE vs Temp tables

Browse pgsql-hackers by date

  From Date Subject
Next Message movead.li@highgo.ca 2020-04-07 01:29:51 Re: A bug when use get_bit() function for a long bytea string
Previous Message Tomas Vondra 2020-04-07 01:13:53 Re: [PATCH] Incremental sort (was: PoC: Partial sort)