| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, hghwng(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #16330: psql accesses null pointer in connect.c:do_connect |
| Date: | 2020-03-31 07:21:53 |
| Message-ID: | 20200331072153.GB1549@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Mon, Mar 30, 2020 at 12:48:51PM -0300, Alvaro Herrera wrote:
> On 2020-Mar-30, Tom Lane wrote:
>> It looks to me like there's a similar hazard a bit further down
>> (line 3029):
>>
>> appendConnStrVal(&connstr, PQdb(o_conn));
>>
>> I wonder if we should force reuse_previous to false if there's
>> no o_conn, rather than fixing this stuff piecemeal.
>
> That was my impression too.
Good point. What do you think about the attached then?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| psql-crash-fix-2.patch | text/x-diff | 514 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2020-03-31 09:37:56 | Re: BUG #16293: postgres segfaults and returns SQLSTATE 08006 |
| Previous Message | Guillaume Lelarge | 2020-03-31 06:43:28 | Re: translation typos |