| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: error context for vacuum to include block number |
| Date: | 2020-03-24 04:16:16 |
| Message-ID: | 20200324041616.GA21443@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 23, 2020 at 02:25:14PM +0530, Amit Kapila wrote:
> > Yea, and it would be misleading if we reported "while scanning block..of
> > relation" if we actually failed while writing its FSM.
> >
> > My previous patches did this:
> >
> > + case VACUUM_ERRCB_PHASE_VACUUM_FSM:
> > + errcontext("while vacuuming free space map of relation \"%s.%s\"",
> > + cbarg->relnamespace, cbarg->relname);
> > + break;
> >
>
> In what kind of errors will this help?
If there's an I/O error on an _fsm file, for one.
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Paul Jungwirth | 2020-03-24 04:23:31 | Re: range_agg |
| Previous Message | Kyotaro Horiguchi | 2020-03-24 04:00:59 | Re: Negative cost is seen for plan node |