Re: Exposing keywords to clients

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Dave Page" <dpage(at)pgadmin(dot)org>
Cc: "Peter Eisentraut" <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>
Subject: Re: Exposing keywords to clients
Date: 2008-05-03 20:06:54
Message-ID: 20194.1209845214@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

"Dave Page" <dpage(at)pgadmin(dot)org> writes:
> Attached is an updated patch, giving the following output.

Oh, one other thing: dropping externs into random modules unrelated to
their source module is completely awful programming style, because there
is nothing preventing incompatible declarations. Put those externs in
keywords.h instead. I suspect you have ignored a compiler warning
about not declaring pg_get_keywords itself, too --- it should be
extern'd in builtins.h.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Dave Page 2008-05-03 20:44:58 Re: Exposing keywords to clients
Previous Message Tom Lane 2008-05-03 20:00:51 Re: Exposing keywords to clients