Re: Exposing keywords to clients

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Dave Page" <dpage(at)pgadmin(dot)org>
Cc: "Peter Eisentraut" <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>
Subject: Re: Exposing keywords to clients
Date: 2008-05-03 20:00:51
Message-ID: 20109.1209844851@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

"Dave Page" <dpage(at)pgadmin(dot)org> writes:
> Attached is an updated patch, giving the following output. The catdesc
> column can be translated.

Documentation has got a couple of problems:

> + contains the keyword, the <structfield>catcode</> column contains a
> + category code of 'U' for unknown, 'C' for column name, 'T' for type or
> + function name or 'U' for unreserved. The <structfield>catdesc</>
> + column contains a localised stribg describing the category.

I wouldn't document the "unknown" case at all, much less document it
incorrectly, and you forgot the "reserved" case, and "stribg"?

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2008-05-03 20:06:54 Re: Exposing keywords to clients
Previous Message Dave Page 2008-05-03 19:44:56 Re: Exposing keywords to clients