Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, jungleboogie0(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'
Date: 2019-08-21 14:02:46
Message-ID: 20190821140246.GE26424@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Wed, Aug 21, 2019 at 09:49:54AM -0400, Alvaro Herrera wrote:
> On 2019-Aug-21, Michael Paquier wrote:
>> I quite like the suggestion from Andres to keep the message simple
>> with "too many jobs for this platform's select()". You are indeed
>> right about the pg_log_fatal() part here, I have changed the patch to
>> do that on my local branch.
>
> Well, it's a user-facing error, so I'd rather make it user-friendly.
> It doesn't seem difficult, or unreliable enough not to try.

Still, in this case, because of the nature of FD_SETSIZE the hint may
finish by being wrong, no? I am not sure that it is worth going this
way.
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Ashutosh Sharma 2019-08-21 14:07:09 Re: BUG #15971: Behaviour of SUBSTR function depending on its arguments
Previous Message Alvaro Herrera 2019-08-21 13:49:54 Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'