Re: TRACE_SORT defined by default

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie>, Joe Conway <mail(at)joeconway(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: TRACE_SORT defined by default
Date: 2019-04-25 20:52:03
Message-ID: 20190425205203.GA11285@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-Apr-25, Jeff Janes wrote:

> I've had people use it to get some insight into the operation and memory
> usage of Aggregate nodes, since those nodes offer nothing useful via
> EXPLAIN ANALYZE. It would be a shame to lose that ability on
> package-installed PostgreSQL unless we fix Aggregate node reporting first.

But the proposal is not to remove the _code_. The proposal is just to
remove that "#ifdef" lines that would make it conditionally compilable,
*if* the symbol that they test weren't always enabled. In other words,
turn it from "always compiled, but you can turn it off although nobody
does" into "always compiled".

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2019-04-25 20:54:58 Re: TRACE_SORT defined by default
Previous Message Tom Lane 2019-04-25 20:36:14 Re: BUG #15781: subselect on foreign table (postgres_fdw) can crash (segfault)