Re: Errors creating partitioned tables from existing using (LIKE <table>) after renaming table constraints

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Stuart <sfbarbee(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Errors creating partitioned tables from existing using (LIKE <table>) after renaming table constraints
Date: 2018-12-17 02:06:34
Message-ID: 20181217020634.GC31474@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Mon, Dec 17, 2018 at 10:51:10AM +0900, Michael Paquier wrote:
> Done just a few moments ago. I have also added a test with a primary
> key rename which does not matter as long as LIKE INCLUDE INDEXES is
> involved but that felt safer in the long-run.

Buildfarm member prion is complaining on that:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2018-12-17%2001%3A46%3A36
This uses -DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE.

It seems that the call to relation_close should happen after
CacheInvalidateRelcache. Damn..
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Amit Langote 2018-12-17 02:18:14 Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction
Previous Message Michael Paquier 2018-12-17 01:51:10 Re: Errors creating partitioned tables from existing using (LIKE <table>) after renaming table constraints