Re: ALTER INDEX ... ALTER COLUMN not present in dump

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Adrien NAYRAT <adrien(dot)nayrat(at)anayrat(dot)info>
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: ALTER INDEX ... ALTER COLUMN not present in dump
Date: 2018-11-21 00:04:17
Message-ID: 20181121000417.GC1951@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Fri, Nov 16, 2018 at 10:31:03PM +0900, Michael Paquier wrote:
> On Fri, Nov 16, 2018 at 05:32:52PM +0900, Michael Paquier wrote:
>> And here you go as attached. Looking closer, in v10 and older versions,
>> ALTER INDEX SET STATISTICS is able to work as it is an alias of ALTER
>> TABLE. The attached patch does not bother generating the ALTER INDEX
>> queries for v10 and older and feeds queries with empty strings. Perhaps
>> we should support that case? Or the lack of complains would be an
>> argument sufficient to care only about v11 and newer versions? I would
>> tend to think that supporting only v11 and above is enough. Thoughts
>> are welcome.

So, any thoughts about this patch? I would still like to move on with
only supporting this set of queries only for v11 and above as that gets
only clearly documented on the ALTER INDEX page from that point.
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Andrew Gierth 2018-11-21 02:47:47 Re: BUG #15514: process fails on jsonb_populate_recordset query. see simple example below
Previous Message Haribabu Kommi 2018-11-20 23:21:39 Re: BUG #15514: process fails on jsonb_populate_recordset query. see simple example below

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-11-21 00:07:58 pgsql: Remove WITH OIDS support, change oid catalog column visibility.
Previous Message Michael Paquier 2018-11-20 23:52:17 Re: CF app feature request