Re: [COMMITTERS] pgsql: Check interrupts during hot standby waits

From: Andres Freund <andres(at)anarazel(dot)de>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Check interrupts during hot standby waits
Date: 2017-01-26 19:06:05
Message-ID: 20170126190605.crxlcwndye7fh4sq@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

On 2017-01-26 19:00:34 +0000, Simon Riggs wrote:
> Check interrupts during hot standby waits
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/pg/commitdiff/e8ee3d6b859a18d7f7375ceb9e04d256eb18aaec
>
> Modified Files
> --------------
> src/backend/storage/ipc/standby.c | 2 ++
> 1 file changed, 2 insertions(+)

It seems that the actual fix here would be to replace the pg_usleep loop
with a latch wait.... Then we also don't need to needlessly loop, and
actually react promptly to signals.

Andres

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2017-01-26 20:07:43 pgsql: Reset hot standby xmin after restart
Previous Message Simon Riggs 2017-01-26 19:00:34 pgsql: Check interrupts during hot standby waits

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-01-26 19:07:08 Re: [PATCH] Generic type subscription
Previous Message Robert Haas 2017-01-26 19:05:43 Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal