Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically
Date: 2017-01-17 21:35:48
Message-ID: 20170117213548.ijzl2uw4edbreyhw@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera wrote:

> It is possible to replace many occurrences of builtins.h with
> fmgrprotos.h. I just tried this
> git grep -l 'include.*utils/builtins.h' -- *.c | xargs perl -pi -e 's{utils/builtins.h}{utils/fmgrprotos.h}'
> There's a large number of changes that the oneliner produces that must
> be reverted for the compile to be silent, but a large portion can
> remain. (I only tried src/backend/access).

92 files are changed, 241 files still require builtins.h.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
include-only-fmgrprotos.patch text/plain 35.2 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2017-01-17 22:18:14 Re: Re: [COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.
Previous Message Alvaro Herrera 2017-01-17 20:30:00 Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-01-17 21:39:30 Re: Re: Clarifying "server starting" messaging in pg_ctl start without --wait
Previous Message Robert Haas 2017-01-17 21:14:19 Re: New SQL counter statistics view (pg_stat_sql)