| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: age(xid) on hot standby |
| Date: | 2012-05-09 14:34:59 |
| Message-ID: | 20168.1336574099@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
>> We should just use MyPgXact->xid
>> rather than add more to the transaction path
>>
>> I'll simplify the patch and commit.
> Committed, but forgot to give appropriate credit. Sorry about that.
This patch didn't fix things, it broke things. The former guarantee
that age's reference point would hold still throughout a transaction
just disappeared.
What I read your previous suggestion to be was that age() would keep
local state and use inspection of the current VXID to tell if its
cache was stale. That would keep the fix localized (which I agree
is a good idea) without losing the stability guarantee.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2012-05-09 15:43:07 | Re: synchronous_commit and remote_write |
| Previous Message | Bruce Momjian | 2012-05-09 14:34:22 | Re: synchronous_commit and remote_write |