From: | "Karl O(dot) Pinc" <kop(at)meme(dot)com> |
---|---|
To: | Gilles Darold <gilles(dot)darold(at)dalibo(dot)com> |
Cc: | Christoph Berg <myon(at)debian(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Shulgin, Oleksandr" <oleksandr(dot)shulgin(at)zalando(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch to implement pg_current_logfile() function |
Date: | 2016-11-19 15:22:20 |
Message-ID: | 20161119092220.3c0ffda4@slate.meme.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Gilles,
On Tue, 15 Nov 2016 15:15:52 -0600
"Karl O. Pinc" <kop(at)meme(dot)com> wrote:
> > On Mon, 7 Nov 2016 23:29:28 +0100
> > Gilles Darold <gilles(dot)darold(at)dalibo(dot)com> wrote:
> > > - Do not write current_logfiles when log_collector is activated
> > > but log_destination doesn't contained stderr or csvlog. This was
> > > creating an empty file that can confuse the user.
> Whether to write current_logfiles only when there's a stderr or csvlog
> seems dependent up on whether the current_logfiles file is for human
> or program use. If for humans, don't write it unless it has content.
> If for programs, why make the program always have to check to see
> if the file exists before reading it? Failing to check is just one
> more cause of bugs.
What are your thoughts on this? I'm leaning toward current_logfiles
being for programs, not people. So it should be present whenever
logging_collector is on.
Regards,
Karl <kop(at)meme(dot)com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-11-19 16:18:33 | Re: [HACKERS] How to change order sort of table in HashJoin |
Previous Message | Andrew Dunstan | 2016-11-19 15:16:34 | Re: Mail thread references in commits |