Re: Comment and function argument names are mismatched in bugmgr.c.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Comment and function argument names are mismatched in bugmgr.c.
Date: 2016-07-01 21:34:03
Message-ID: 20160701213403.l2cl4xsqwarfj2nm@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2016-06-23 16:24:12 +0900, Masahiko Sawada wrote:
> By commit 428b1d6b, function WritebackContextInit is added but the
> comment of this function seems to be incorrect.
> *max_coalesce variable doesn't exist at anywhere.
> Also, I think it should be fixed that the argument name of this
> function does not match function declare in buf_internal.h.
> Patch for that attached.

Fix looks good to me, and your 'bugmgr.c' typo in $subject made me laugh
;). Pushed.

Thanks Robert, for pointing me to the thread, I had indeed missed it.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2016-07-01 21:51:51 Re: pg_replication_origin_xact_reset() and its argument variables
Previous Message Tom Lane 2016-07-01 21:29:36 Re: [sqlsmith] ERROR: plan should not reference subplan's variable