From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
Cc: | Thom Brown <thom(at)linux(dot)com>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [BUGS] Breakage with VACUUM ANALYSE + partitions |
Date: | 2016-04-27 03:35:57 |
Message-ID: | 20160427033557.vbu4gylfltqmrhsj@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
Hi,
On 2016-04-25 20:53:26 +0200, Fabien COELHO wrote:
> I have just a small naming point:
>
> /* ereport if segment not present, create in recovery */
> EXTENSION_FAIL,
> /* return NULL if not present, create in recovery */
> EXTENSION_RETURN_NULL,
> /* return NULL if not present */
> EXTENSION_REALLY_RETURN_NULL,
> /* create new segments as needed */
> EXTENSION_CREATE
>
> The comments seem pretty clear, but the naming of these options are more
> behavioral than functional somehow (or the reverse?), especially the
> RETURN_NULL and REALLY_RETURN_NULL names seemed pretty contrived to me.
I tend to agree. But "fixing" that would mean changing quite some
additional pieces of code, more than I want to do in a bugfix. I also
think it's not *that* confusing...
Thanks for looking.
Andres
From | Date | Subject | |
---|---|---|---|
Next Message | mso1830 | 2016-04-27 08:02:51 | BUG #14116: Character with value 0x0a must be escaped. using COPY FROM |
Previous Message | Michael Paquier | 2016-04-27 00:58:45 | Re: BUG #14109: pg_rewind fails to update target control file in one scenario |
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2016-04-27 03:38:12 | Re: EXPLAIN VERBOSE with parallel Aggregate |
Previous Message | Etsuro Fujita | 2016-04-27 03:16:01 | Re: Optimization for updating foreign tables in Postgres FDW |