| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <rhaas(at)postgresql(dot)org> |
| Subject: | Re: Yet another small patch - reorderbuffer.c:1099 |
| Date: | 2016-04-05 09:12:35 |
| Message-ID: | 20160405091235.avds6xcqlzp7yd5l@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2016-04-05 12:07:40 +0300, Aleksander Alekseev wrote:
> > I recall discussing this code with Andres, and I think that he has
> > mentioned me this is intentional, because should things be changed for
> > a reason or another in the future, we want to keep in mind that a list
> > of TXIDs and a list of sub-TXIDs should be handled differently.
>
> I see. If this it true I think there should be a comment that explains
> it. When you read such a code you suspect a bug. Not mentioning that
> static code analyzers (I'm currently experimenting with Clang and PVS
> Studio) complain about code like this.
There's different comments in both branches...
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2016-04-05 09:13:50 | Re: Support for N synchronous standby servers - take 2 |
| Previous Message | Fujii Masao | 2016-04-05 09:10:24 | Re: Support for N synchronous standby servers - take 2 |