From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Ian Barwick <ian(at)2ndquadrant(dot)com> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Correction for replication slot creation error message in 9.6 |
Date: | 2016-03-31 08:10:31 |
Message-ID: | 20160331081031.GJ13305@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2016-03-31 10:15:21 +0900, Ian Barwick wrote:
> Hi
>
> Currently pg_create_physical_replication_slot() may refer to
> the deprecated wal_level setting "archive":
>
> postgres=# SHOW wal_level ;
> wal_level
> -----------
> minimal
> (1 row)
>
> postgres=# SELECT pg_create_physical_replication_slot('some_slot');
> ERROR: replication slots can only be used if wal_level is >= archive
>
> Patch changes the error message to:
>
> ERROR: replication slots can only be used if wal_level is "replica" or "logical"
>
> Explicitly naming the valid WAL levels matches the wording in the wal_level
> error hint used in a couple of places, i.e.
The explicit naming makes it much more verbose to change anything around
wal level though, so consider me not a fan of spelling out all levels.
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2016-03-31 08:10:57 | Re: Very small patch for decode.c |
Previous Message | Andres Freund | 2016-03-31 08:09:07 | Re: Timeline following for logical slots |