| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Tatsuo Ishii <ishii(at)postgresql(dot)org>, jeff(dot)janes(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: multivariate statistics v14 |
| Date: | 2016-03-24 17:45:20 |
| Message-ID: | 20160324174520.GA676490@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tomas Vondra wrote:
> >+ values[Anum_pg_mv_statistic_stamcv - 1] = PointerGetDatum(data);
> >
> >Why the double space (that's actually in several places in several of
> >the patches).
>
> To align the whole block like this:
>
> nulls[Anum_pg_mv_statistic_stadeps -1] = true;
> nulls[Anum_pg_mv_statistic_stamcv -1] = true;
> nulls[Anum_pg_mv_statistic_stahist -1] = true;
> nulls[Anum_pg_mv_statistic_standist -1] = true;
>
> But I won't fight for this too hard, if it breaks rules somehow.
Yeah, it will be undone by pgindent. I suggest you pgindent all the
patches in the series. With some clever patch vs. patch -R application,
you can do it without having to resolve any conflicts when pgindent
modifies code that a patch further up in the series modifies again.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2016-03-24 17:45:40 | Re: [PATCH] we have added support for box type in SP-GiST index |
| Previous Message | Aleksey Demakov | 2016-03-24 17:20:22 | Re: Rationalizing code-sharing among src/bin/ directories |