Re: fd.c doesn't remove files on a crash-restart

From: Andres Freund <andres(at)anarazel(dot)de>
To: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: fd.c doesn't remove files on a crash-restart
Date: 2016-03-16 18:08:52
Message-ID: 20160316180852.hytxrba6n3qyw36x@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2016-03-16 11:06:23 -0700, Joshua D. Drake wrote:
> On 03/16/2016 11:04 AM, Andres Freund wrote:
> >On 2016-03-16 11:02:09 -0700, Joshua D. Drake wrote:
> >>>>3. The problem can get worse over time. If you have a very long running
> >>>>instance, any time the backend crash-restarts you have to potential to
> >>>>increase disk space used for no purpose.
> >>>
> >>>But I think these outweigh the debugging benefit.
> >>
> >>Well as Andrew said, we could also create postmaster start option that
> >>defaults to don't save.
> >
> >I think these days you'd simply use restart_after_crash = false. For
> >debugging I found that to be rather valuable.
>
> That would have created an extended outage for this installation. I am not
> sure we can force that for something that should not happen in the first
> place (filling up the hard drive with dead files).

Nah, I meant that if you want to debug something you'd set that (i.e. in
the case you need the temp files), not you should set that.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-03-16 18:14:22 Re: Pushdown target list below gather node (WAS Re: WIP: Upper planner pathification)
Previous Message Joshua D. Drake 2016-03-16 18:07:06 Re: fd.c doesn't remove files on a crash-restart