From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Only try to push down foreign joins if the user mapping OIDs mat |
Date: | 2016-03-12 03:15:02 |
Message-ID: | 20160312031502.lqtbqnqor4vji62k@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2016-01-28 19:09:01 +0000, Robert Haas wrote:
> Only try to push down foreign joins if the user mapping OIDs match.
>
> Previously, the foreign join pushdown infrastructure left the question
> of security entirely up to individual FDWs, but it would be easy for
> a foreign data wrapper to inadvertently open up subtle security holes
> that way. So, make it the core code's job to determine which user
> mapping OID is relevant, and don't attempt join pushdown unless it's
> the same for all relevant relations.
>
> Per a suggestion from Tom Lane. Shigeru Hanada and Ashutosh Bapat,
> reviewed by Etsuro Fujita and KaiGai Kohei, with some further
> changes by me.
I noticed that this breaks some citus regression tests in a minor
manner. Namely previously file_fdw worked without a user mapping, now it
doesn't appear to anymore.
This is easy enough to fix, and it's perfectly ok for us to fix this,
but I do wonder if that's not going to cause trouble for others.
Andres
From | Date | Subject | |
---|---|---|---|
Next Message | Joel Jacobson | 2016-03-12 05:54:29 | Re: [COMMITTERS] pgsql: Provide much better wait information in pg_stat_activity. |
Previous Message | Jim Nasby | 2016-03-11 23:31:13 | Re: [COMMITTERS] pgsql: Provide much better wait information in pg_stat_activity. |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-03-12 03:30:12 | Re: pl/pgSQL, get diagnostics and big data |
Previous Message | Amit Kapila | 2016-03-12 03:07:59 | Re: Relation extension scalability |