Re: Template for commit messages

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Template for commit messages
Date: 2016-01-30 10:22:50
Message-ID: 20160130102250.GA10783@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas wrote:
> On Fri, Jan 29, 2016 at 6:05 PM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:

> > Personally I don't see value in having the commit message follow a
> > machine-parseable format; like if you say "Backpatch to" instead of
> > "Backpatch-through:" makes your commit message wrong. I think what was
> > being proposed is to have committers ensure that the commit messages
> > always carried the necessary info (which, as far as I know, they do.)
>
> Well, this gets at one of the problems here, which is that you can't
> fix a commit message once the commit has been pushed.

Yes, I'm aware that this is a problem. I tried to raise the point that
we could use "git notes" to provide additional information after the
fact but was quickly made to shut up before it could be recorded in the
minutes.

If we were to adopt git notes or a similar system(*), we could use those
as a mechanism to install the machine-parseable data for each commit,
which I think fixes all the problems you point out.

(*) Another idea that comes to mind now that you mention this database
thingy of yours is to make a table or tables with commits and their
associated data, which could initially be populated from the commit
message and later updated.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-01-30 12:36:27 Re: extend pgbench expressions with functions
Previous Message Robert Haas 2016-01-30 10:11:21 Re: Template for commit messages