Re: oldest/newestCommitTs output by pg_controldata

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Joe Conway <mail(at)joeconway(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: oldest/newestCommitTs output by pg_controldata
Date: 2015-12-28 18:30:35
Message-ID: 20151228183035.GL58441@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Joe Conway <mail(at)joeconway(dot)com> writes:
> > I think the attached does the job. Note I settled on
> > (new|old)estCommitTsXid as that seemed most descriptive and not horribly
> > longer than before. It did mean, however, that I needed to add a single
> > space to all the output in pg_resetxlog and pg_controldata, which added
> > a fair amount to the patch size.
>
> Hm. That will break all the translations for those messages, no?
> Not sure it's worth it.

Yeah, I would leave the others alone and just let this line have the
value shifted one more column to the right.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2015-12-28 18:31:59 Re: 9.5rc1 brin_summarize_new_values
Previous Message Alvaro Herrera 2015-12-28 18:29:15 pgsql: Document brin_summarize_new_pages