| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Euler Taveira <euler(at)timbira(dot)com(dot)br>, Bernd Helmle <mailings(at)oopsware(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Duplicated assignment of slot_name in walsender.c |
| Date: | 2015-10-21 21:33:19 |
| Message-ID: | 20151021213319.GG32218@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015-10-21 17:21:25 -0300, Alvaro Herrera wrote:
> > It seems that the 2nd assignment was an oversight. Spotted by Bernd
> > Helmle.
Yea, that's obviously redudant. Will remove.
> I think the first assignment is also pointless -- I mean can't we just
> use MyReplicationSlot->data.name in both places where slot_name is used?
Makes the lines a bit long. strlen(NameStr(MyReplicationSlot->data.name)) ...
> In the same routine, it seems wasteful to be doing strlen() twice for
> every string sent over the wire.
That seems fairly insignificant. For one this is a rather infrequent and
expensive operation, for another every decent compiler can optimize
those away. Note that those duplicate strlen() calls are there in a lot
of places in walsender.c
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-10-21 21:36:26 | Re: pg_recvlogical fixes |
| Previous Message | Alvaro Herrera | 2015-10-21 20:21:25 | Re: Duplicated assignment of slot_name in walsender.c |