Re: PATCH: 9.5 replication origins fix for logical decoding

From: Andres Freund <andres(at)anarazel(dot)de>
To: Craig Ringer <craig(at)2ndquadrant(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: 9.5 replication origins fix for logical decoding
Date: 2015-10-15 08:48:45
Message-ID: 20151015084845.GB6851@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2015-10-15 16:02:23 +0800, Craig Ringer wrote:
> There's an oversight in replication origins support in logical
> decoding, where the origin node ID isn't passed correctly to callbacks
> except for the origin filter callback. All other callbacks see it as
> InvalidRepOriginId.

Only for the transaction, right? I.e. the stuff on changes should be
correct? Your description sounds like it's more than that?

I don't think your fix is entirely correct, the
XLogRecGetOrigin(buf->record) shouldn't be in the XACT_XINFO_HAS_ORIGIN
block.

Your test prints the origins from the transaction instead the changes -
why?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2015-10-15 09:05:33 Re: PATCH: 9.5 replication origins fix for logical decoding
Previous Message kolo hhmow 2015-10-15 08:41:56 Re: pam auth - add rhost item