From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | oonishitk(at)nttdata(dot)co(dot)jp, pgsql-docs <pgsql-docs(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: max_worker_processes on the standby |
Date: | 2015-10-01 18:12:40 |
Message-ID: | 20151001181240.GT2573@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs pgsql-hackers |
Fujii Masao wrote:
> I've not read the patch yet, but the patched server with track_commit_timestamp
> enabled caused the following PANIC error when I ran pgbench.
Ah, that was a stupid typo: I used || instead of &&. Fixed that.
I also changed DeactivateCommitTs() so that it removes all slru segments
instead of leaving the last one around (which is what SimpleLruTruncate
was doing). This was noticeable when you ran a server with the feature
enabled (which created some files), then disabled it (which removed all
but the last) and ran for some more xacts; then enabled it again (which
created a new file, far ahead from the previously existing one). Since
the feature has enough protections that it doesn't have a problem with
no files at all being present, this works correctly. Note no
wal-logging of this operation: it's not necessary AFAICS because the
same deactivation routine would be called again in recovery and in
XLOG_PARAMETER_CHANGE, so it should be safe.
And pushed.
Thanks!
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2015-10-02 03:06:03 | Re: [DOCS] max_worker_processes on the standby |
Previous Message | Fujii Masao | 2015-10-01 14:14:30 | Re: storage.sgml mentioning htup.h when referring to HeapTupleHeaderData |
From | Date | Subject | |
---|---|---|---|
Next Message | Merlin Moncure | 2015-10-01 20:21:12 | Re: No Issue Tracker - Say it Ain't So! |
Previous Message | Stefan Kaltenbrunner | 2015-10-01 17:25:30 | Re: No Issue Tracker - Say it Ain't So! |