Re: pg_controldata output alignment regression

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>
Subject: Re: pg_controldata output alignment regression
Date: 2015-08-25 19:41:24
Message-ID: 20150825194124.GF2912@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Joe Conway wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1

I should have gotten my key signed when I had the chance :-(

> On 08/25/2015 11:28 AM, Alvaro Herrera wrote:
> > Joe Conway wrote:
> >
> >> Does anyone out there object to a non-backward compatible change
> >> to pg_controldata output?
> >
> > I don't (and thanks for taking care of it), but as I recall,
> > pg_upgrade reads and interprets pg_controldata output so it may
> > need adjustment too.
>
> Thanks for the heads up. There are lots of controldata items
> pg_upgrade is interested in, but AFAICS none of these are included.
> Now maybe they should be, but they are not currently referenced.

Well, if there's no compatibility hit then I don't think it's worth
worrying about.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Aaron W. Swenson 2015-08-25 19:43:12 Re: 9.4 broken on alpha
Previous Message Joe Conway 2015-08-25 19:23:19 Re: pg_controldata output alignment regression