Re: pgsql: Optionally don't error out due to preexisting slots in commandli

From: Andres Freund <andres(at)anarazel(dot)de>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Optionally don't error out due to preexisting slots in commandli
Date: 2015-08-12 15:38:25
Message-ID: 20150812153825.GC25424@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2015-08-12 15:09:21 +0900, Michael Paquier wrote:
> Andres, Coverity is pointing out that this commit missed the shot when
> sqlstate is NULL in CreateReplicationSlot and this would crash.
> Something like the patch attached look adapted to me, vacuumdb.c doing
> the necessary checks similarly.

Thanks, fixed!

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2015-08-12 17:21:35 pgsql: Close some holes in BRIN page assignment
Previous Message Andres Freund 2015-08-12 15:37:30 pgsql: Handle PQresultErrorField(PG_DIAG_SQLSTATE) returning NULL in st