From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: FSM versus GIN pending list bloat |
Date: | 2015-08-04 17:20:49 |
Message-ID: | 20150804172049.GR2441@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Jeff Janes wrote:
> The attached proof of concept patch greatly improves the bloat for both the
> insert and the update cases. You need to turn on both features: adding the
> pages to fsm, and vacuuming the fsm, to get the benefit (so JJ_GIN=3). The
> first of those two things could probably be adopted for real, but the
> second probably is not acceptable. What is the right way to do this?
I think that's the right way, only that I wouldn't call FSMVacuum()
inside the loop but only once you're out of it.
FWIW I had to add a FSMVacuum call somewhere in the BRIN code also,
which I didn't like at all. If there's a way to optimize this "bubbling
up" of some individual page all the way to the root level, that would
probably be a lot better than what it's currently doing.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2015-08-04 17:20:55 | Re: track_commit_timestamp and COMMIT PREPARED |
Previous Message | Andres Freund | 2015-08-04 17:18:11 | Re: track_commit_timestamp and COMMIT PREPARED |