| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | robertmhaas(at)gmail(dot)com, sfrost(at)snowman(dot)net |
| Subject: | Re: nodes/*funcs.c inconsistencies |
| Date: | 2015-08-02 20:28:43 |
| Message-ID: | 20150802202843.GA1711133@tornado.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 16, 2012 at 06:25:15AM -0400, Noah Misch wrote:
> I observed these inconsistencies in node support functions:
A fresh audit found the attached problems new in 9.5[1]. Most are cosmetic
INT/UINT or field order corrections. The non-cosmetic changes involve
CustomPath, CustomScan, and CreatePolicyStmt. Feature committers, if the
existing treatments (ignore custom_plans/custom_paths fields; copy/compare
"cmd" string pointer as a scalar) were deliberate, please let me know.
Thanks,
nm
[1] The _equalCreateEventTrigStmt() cosmetic change is relevant as far back as
9.3, but I won't back-patch it further than the others (9.5).
| Attachment | Content-Type | Size |
|---|---|---|
| nodefuncs-95features-v1.patch | text/plain | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-08-02 21:37:42 | Re: nodes/*funcs.c inconsistencies |
| Previous Message | Tom Lane | 2015-08-02 20:18:30 | Re: [sqlsmith] Failed assertion in joinrels.c |