Re: [Postgresql Master Branch Patch] object class patch

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Jaimin Pan <jaimin(dot)pan(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: [Postgresql Master Branch Patch] object class patch
Date: 2015-07-18 15:14:34
Message-ID: 20150718151434.GX2301@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Michael Paquier wrote:
> On Sun, Jul 12, 2015 at 9:21 PM, Jaimin Pan <jaimin(dot)pan(at)gmail(dot)com> wrote:
> > There is missing mapping for TransformRelationId and OCLASS_TRANSFORM in
> > object_classes.
> >
> > Please check if it need fix.
>
> Right. This has been forgotten in ad89a5d.

But see
https://www.postgresql.org/message-id/CA+Tgmoa6SgDaxW_n_7SEhwBAc=mniYga+obUj5fmw4rU9_mLvA@mail.gmail.com

We should really have some mechanism to detect when this is missed,
because it evidently is very easy to miss. Did anyone review Jim's
patch?

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Alvaro Herrera 2015-07-18 15:54:21 Re: Lack of Sanity Checking in file 'pctcl.c' for PostgreSQL 9.4.x
Previous Message Michael Paquier 2015-07-18 13:25:30 Re: pgadmin-sql window-favourite-Manage...Crash

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2015-07-18 15:38:59 Re: object_classes array is broken, again
Previous Message Tatsuo Ishii 2015-07-18 14:38:53 Re: BRIN index and aborted transaction