| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Nitpicking: unnecessary NULL-pointer check in pg_upgrade's controldata.c |
| Date: | 2015-06-26 13:06:39 |
| Message-ID: | 20150626130639.GE4797@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2015-06-26 22:03:05 +0900, Michael Paquier wrote:
> Hi,
>
> Coverity is nitpickingly pointing out the following thing:
> --- a/src/bin/pg_upgrade/controldata.c
> +++ b/src/bin/pg_upgrade/controldata.c
> @@ -402,8 +402,7 @@ get_control_data(ClusterInfo *cluster, bool live_check)
> }
> }
>
> - if (output)
> - pclose(output);
> + pclose(output);
> The thing is that output can never be NULL, pg_upgrade leaving with
> pg_fatal before coming to this code path. Hence this NULL check could
> be simply removed.
FWIW, I think these type of coverity items should just be discarded with
prejudice. Fixing them doesn't seem to buy anything and there's enough
actually worthwhile stuff going on.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-06-26 13:09:15 | Re: PGXS "check" target forcing an install ? |
| Previous Message | Michael Paquier | 2015-06-26 13:03:05 | Nitpicking: unnecessary NULL-pointer check in pg_upgrade's controldata.c |