| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Teodor Sigaev <teodor(at)sigaev(dot)ru>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: point_ops for GiST |
| Date: | 2015-05-12 18:13:33 |
| Message-ID: | 20150512181333.GA2519@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera wrote:
> Robert Haas wrote:
> > 2009/12/30 Teodor Sigaev <teodor(at)sigaev(dot)ru>:
> > > Sync with current CVS
> >
> > I have reviewed this patch and it looks good to me. The only
> > substantive question I have is why gist_point_consistent() uses a
> > different coding pattern for the box case than it does for the polygon
> > and circle cases? It's not obvious to me on the face of it why these
> > aren't consistent.
>
> Emre Hasegeli just pointed out to me that this patch introduced
> box_contain_pt() and in doing so used straight C comparison (<= etc)
> instead of FPlt() and friends.
(This is commit 4cbe473938779ec414d90c2063c4398e68a70838)
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Eva7 | 2015-05-12 18:19:07 | Re: mogrify and indent features for jsonb |
| Previous Message | Alvaro Herrera | 2015-05-12 18:13:07 | Re: point_ops for GiST |