| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | hlinnaka <hlinnaka(at)iki(dot)fi>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0, parser/executor stuff |
| Date: | 2015-04-27 14:28:49 |
| Message-ID: | 20150427142849.GD7296@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-admin pgsql-hackers |
On 2015-04-26 18:02:06 -0700, Peter Geoghegan wrote:
> * So far, there has been a lack of scrutiny about what the patch does
> in the rewriter (in particular, to support the EXCLUDED.* pseudo-alias
> expression) and optimizer (the whole concept of an "auxiliary"
> query/plan that share a target RTE, and later target ResultRelation).
> If someone took a close look at that, it would be most helpful.
> ruleutils.c is also modified for the benefit of EXPLAIN output. This
> all applies only to the ON CONFLICT UPDATE patch. A committer could
> push out the IGNORE patch before this was 100% firm.
I'm far from an expert on the relevant regions; but I'm starting to look
nonetheless. I have to say that on a preliminary look it looks more
complicated than it has to.
Tom, any chance you could have a look at the parse->analsys->executor
transformations?
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-04-27 21:52:58 | Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0, parser/executor stuff |
| Previous Message | Andres Freund | 2015-04-27 13:43:25 | Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sawada Masahiko | 2015-04-27 14:31:12 | Re: Proposal: knowing detail of config files via SQL |
| Previous Message | Pavel Stehule | 2015-04-27 14:21:37 | Re: PL/pgSQL, RAISE and error context |