Re: Moving ExecInsertIndexTuples and friends to new file

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: hlinnaka <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Moving ExecInsertIndexTuples and friends to new file
Date: 2015-04-24 03:30:35
Message-ID: 20150424033035.GT30322@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

* Peter Geoghegan (pg(at)heroku(dot)com) wrote:
> On Thu, Apr 23, 2015 at 12:05 PM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> > While looking at Peter's INSERT ... ON CONFLICT patch, I started to feel
> > that ExecInsertIndexTuples() and friends would deserve a file of their own,
> > and not be buried in the middle of execUtils.c. I propose that we split
> > execUtils.c into two, moving ExecOpenIndices(), ExecCloseIndices()
> > ExecInsertIndexTuples() and related functions into a new file called
> > executor/execIndexing.c.
>
> That split makes a lot of sense to me.

No objections here.

Thanks!

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2015-04-24 03:31:53 Re: [committers] pgsql: RLS fixes, new hooks, and new test module
Previous Message Tom Lane 2015-04-24 03:24:46 Re: Fwd: [GENERAL] 4B row limit for CLOB tables