Re: [BUGS] BUG #11805: Missing SetServiceStatus call during service shutdown in pg_ctl (Windows only)

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: krystian(dot)bigaj(at)gmail(dot)com
Cc: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: [BUGS] BUG #11805: Missing SetServiceStatus call during service shutdown in pg_ctl (Windows only)
Date: 2015-03-20 12:48:29
Message-ID: 20150320124829.GK6317@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Tue, Oct 28, 2014 at 07:02:41AM +0000, krystian(dot)bigaj(at)gmail(dot)com wrote:
> The following bug has been logged on the website:
>
> Bug reference: 11805
> Logged by: Krystian Bigaj
> Email address: krystian(dot)bigaj(at)gmail(dot)com
> PostgreSQL version: 9.3.5
> Operating system: Windows 7 Pro x64
> Description:
>
> pg_ctl on Windows during service start/shutdown should notify service
> manager about it's status by increment dwCheckPoint and call to
> SetServiceStatus/pgwin32_SetServiceStatus.
>
> However during shutdown there is a missing call to SetServiceStatus.
> See src\bin\pg_ctl\pg_ctl.c:

[ thread moved to hackers ]

Can a Windows person look into this issue?

http://www.postgresql.org/message-id/20141028070241.2593.58180@wrigleys.postgresql.org

The thread includes a patch. I need a second person to verify its
validity. Thanks.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Asif Naeem 2015-03-20 14:14:03 Re: pg_upgrade failure on Windows Server
Previous Message mariusz.kacala 2015-03-20 12:04:50 BUG #12883: Configurable identifier length truncation.

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2015-03-20 13:06:52 Re: configure can't detect proper pthread flags
Previous Message David Fetter 2015-03-20 12:43:37 Re: POLA violation with \c service=