Re: One question about security label command

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>, 张元超 <zhangyuanchao(at)highgo(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: One question about security label command
Date: 2015-03-10 13:41:01
Message-ID: 20150310134101.GC3291@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Kohei KaiGai wrote:
> The attached patch revises error message when security label
> is specified on unsupported object.
> getObjectTypeDescription() may be better than oid of catalog.

Agreed.

> postgres=# SECURITY LABEL FOR selinux ON ROLE kaigai
> postgres-# IS 'system_u:object_r:unlabeled_t:s0';
> ERROR: sepgsql provider does not support labels on role

I'd make it
sepgsql provider does not support labels on objects of type "%s"

And perhaps make it an ereport also, with errcode etc.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2015-03-10 13:48:33 Re: moving from contrib to bin
Previous Message Alvaro Herrera 2015-03-10 13:32:03 Re: Relation ordering in FROM clause causing error related to missing entry... Or not.