| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | "Syed, Rahila" <Rahila(dot)Syed(at)nttdata(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, "Michael Paquier (michael(dot)paquier(at)gmail(dot)com)" <michael(dot)paquier(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Subject: | Re: [REVIEW] Re: Compression of full-page-writes |
| Date: | 2015-03-05 13:28:01 |
| Message-ID: | 20150305132801.GE12445@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015-03-05 12:14:04 +0000, Syed, Rahila wrote:
> Please find attached a patch. As discussed, flag to denote
> compression and presence of hole in block image has been added in
> XLogRecordImageHeader rather than block header.
FWIW, I personally won't commit it with things done that way. I think
it's going the wrong way, leading to a harder to interpret and less
flexible format. I'm not going to further protest if Fujii or Heikki
commit it this way though.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2015-03-05 13:36:29 | Re: anyarray |
| Previous Message | Michael Paquier | 2015-03-05 13:08:03 | Re: [REVIEW] Re: Compression of full-page-writes |