Re: Error check always bypassed in tablefunc.c

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Error check always bypassed in tablefunc.c
Date: 2015-01-16 15:33:01
Message-ID: 20150116153301.GU1663@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier wrote:

> As mentioned in $subject, commit 08c33c4 of 2003 has made the
> following block of code dead in tablefunc.c:1320 because level is
> incremented to at least 1:
> /* First time through, do a little more setup */
> if (level == 0)
> {

Uh. This means the error case has no test coverage ...

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2015-01-16 15:37:23 Re: Safe memory allocation functions
Previous Message Noah Misch 2015-01-16 15:25:55 Re: orangutan seizes up during isolation-check