Re: libpq-dev: pg_config_manual.h redefines CACHE_LINE_SIZE

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Subject: Re: libpq-dev: pg_config_manual.h redefines CACHE_LINE_SIZE
Date: 2014-10-01 10:24:42
Message-ID: 20141001102442.GC2084@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2014-09-30 21:57:56 +0200, Christoph Berg wrote:
> Hi,
>
> there's a #define clash between pg_config_manual.h and FreeBSD's
> /usr/include/machine-amd64/param.h which also defines CACHE_LINE_SIZE.
>
> It's probably not really a PostgreSQL bug, but it seems easy enough to
> rename that definition now as it's only present in 9.4+. It's only
> used in one file, xlog.c: 375d8526f2900d0c377f44532f6d09ee06531f67

Changed in 9.4/master.

Thanks.

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2014-10-01 10:50:02 Re: "Value locking" Wiki page
Previous Message Andres Freund 2014-10-01 10:10:13 Re: "Value locking" Wiki page