| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
| Subject: | Re: libpq-dev: pg_config_manual.h redefines CACHE_LINE_SIZE |
| Date: | 2014-09-30 21:03:28 |
| Message-ID: | 20140930210328.GT2084@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-09-30 13:42:11 -0700, Peter Geoghegan wrote:
> On Tue, Sep 30, 2014 at 12:57 PM, Christoph Berg <myon(at)debian(dot)org> wrote:
> > It's probably not really a PostgreSQL bug, but it seems easy enough to
> > rename that definition now as it's only present in 9.4+. It's only
> > used in one file, xlog.c: 375d8526f2900d0c377f44532f6d09ee06531f67
>
>
> I agree. It should be renamed to PG_CACHE_LINE_SIZE.
Agreed. Unless somebody protests I'll do so tomorrow.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gavin Flower | 2014-09-30 21:11:20 | Re: Yet another abort-early plan disaster on 9.3 |
| Previous Message | Peter Geoghegan | 2014-09-30 20:42:11 | Re: libpq-dev: pg_config_manual.h redefines CACHE_LINE_SIZE |