Re: pg_upgrade < 9.3 -> >=9.3 misses a step around multixacts

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: pg_upgrade < 9.3 -> >=9.3 misses a step around multixacts
Date: 2014-06-20 17:19:15
Message-ID: 20140620171915.GC29143@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Thu, Jun 19, 2014 at 06:12:41PM -0400, Alvaro Herrera wrote:
> BTW I hacked up pg_resetxlog a bit to make it generate the necessary
> pg_multixact/offset file when -m is given. This is not acceptable for
> commit because it duplicates the #defines from pg_multixact.c, but maybe
> we want this functionality enough that we're interested in a more
> complete version of this patch; also it unconditionally writes one zero
> byte to the file, which is of course wrong if the file exists and
> already contains data.

Why would we want this if the system functions fine without those files
being created? I don't think we want pg_resetxlog to be doing anything
except changing pg_controldata.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Alvaro Herrera 2014-06-20 17:33:52 Re: pg_upgrade < 9.3 -> >=9.3 misses a step around multixacts
Previous Message Bruce Momjian 2014-06-20 17:17:38 Re: pg_upgrade < 9.3 -> >=9.3 misses a step around multixacts