Re: slotname vs slot_name

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: slotname vs slot_name
Date: 2014-06-05 11:43:48
Message-ID: 20140605114348.GK2789@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2014-06-05 12:57:57 +0200, Andres Freund wrote:
> On 2014-06-05 10:57:58 +0900, Fujii Masao wrote:
> > I like using "slot_name" everywhere, i.e, even in recovery.conf.
> > primary_slot_name seems not so long name.
>
> It also has the advantage that we can add a couple more slot_* options
> later. Will do that.

Ok. Here's a patch using slot_name everywhere user visible. There's a
couple of places in the code where 'slotname' is still used, but those
look more consistent that way in their context. I'll push that later
unless somebody suggests changes.

It's much easier to review changes after applying them when using
--word-diff=color --word-diff-regex='[^[:space:]\<\>\,]+'
as parameters to git diff/show.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
0001-Consistently-spell-a-replication-slot-s-name-as-slot.patch text/x-patch 26.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Gurjeet Singh 2014-06-05 12:09:07 Re: Proposing pg_hibernate
Previous Message Linos 2014-06-05 11:32:27 performance regression in 9.2/9.3