| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Reset master xmin when hot_standby_feedback disabled. |
| Date: | 2014-05-28 22:36:40 |
| Message-ID: | 20140528223640.GD27914@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hi,
On 2013-02-04 10:35:31 +0000, Simon Riggs wrote:
> Reset master xmin when hot_standby_feedback disabled.
> If walsender has xmin of standby then ensure we
> reset the value to 0 when we change from hot_standby_feedback=on
> to hot_standby_feedback=off.
Unless somebody protests I'd like to backpatch this change to 9.2 and
9.1. This imo is a bugfix, not a new feature. What currently happens <
9.3 when hot_standby_feedback is disabled after being enabled is that
the walsender's xmin horizon doesn't increase until disconnected. That's
pretty hard to diagnose and can cause severe problems.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2014-05-28 22:39:56 | Re: pgsql: Reset master xmin when hot_standby_feedback disabled. |
| Previous Message | Andres Freund | 2014-05-28 22:33:06 | pgsql: Don't pay heed to wal_sender_timeout while creating a decoding s |