| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Allowing line-continuation in pgbench custom scripts |
| Date: | 2014-05-26 15:37:52 |
| Message-ID: | 20140526153752.GY7857@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Amit Langote wrote:
> On Mon, May 26, 2014 at 10:59 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> > On Mon, May 26, 2014 at 6:50 PM, Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> >> Thoughts?
> >
> > IMO it's better if we can write SQL in multiples line *without* a tailing
> > escape character, like psql's input file.
>
> Yeah, that would be much cleaner.
But that would require duplicating the lexing stuff to determine where
quotes are and where commands end. There are already some cases where
pgbench itself is the bottleneck; adding a lexing step would be more
expensive, no? Whereas simply detecting line continuations would be
cheaper.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-05-26 15:44:31 | Re: Allowing line-continuation in pgbench custom scripts |
| Previous Message | Amit Langote | 2014-05-26 15:33:12 | pg_llog not mentioned in "Database File Layout" |