| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, jhedden(at)apple(dot)com, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #9118: WAL Sender does not disconnect replication clients during shutdown |
| Date: | 2014-03-18 17:20:47 |
| Message-ID: | 20140318172047.GY16438@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 2014-03-19 02:16:00 +0900, Fujii Masao wrote:
> > Comments of WalSndWaitForWal would need an update as well in this
> > case. It is written on top of this function that it waits "until WAL <
> > loc is flushed to disk".
>
> I don't think that comment needs to be updated because it means that
> "until WAL < loc is flushed to the *master local* disk". It's not related to
> the flush location that the standby returns. Anyway, I attached the patch.
> Barring objection, I will commit this.
I object on behalf of WalSndWaitForWal(). We really need the flush
location there because otherwise we can't remove old WAL.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2014-03-18 17:53:18 | Re: BUG #9118: WAL Sender does not disconnect replication clients during shutdown |
| Previous Message | Fujii Masao | 2014-03-18 17:16:00 | Re: BUG #9118: WAL Sender does not disconnect replication clients during shutdown |