Leaking regexp_replace in 9.3.1 ? (was: [HACKERSUninterruptable regexp_replace in 9.3.1 ?)

From: Sandro Santilli <strk(at)keybit(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Florian Pflug <fgp(at)phlo(dot)org>, pgsql-bugs(at)postgresql(dot)org
Subject: Leaking regexp_replace in 9.3.1 ? (was: [HACKERSUninterruptable regexp_replace in 9.3.1 ?)
Date: 2014-03-18 17:04:01
Message-ID: 20140318170401.GE29859@localhost
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Wed, Feb 26, 2014 at 04:01:13PM +0100, Sandro Santilli wrote:
> On Fri, Feb 21, 2014 at 08:17:36PM -0500, Tom Lane wrote:
> > I wrote:
> > > Craig Ringer <craig(at)2ndquadrant(dot)com> writes:
> > >> So I'd like to confirm that this issue doesn't affect 9.1.
> >
> > > It doesn't. I suspect it has something to do with 173e29aa5 or one
> > > of the nearby commits in backend/regex/.
> >
> > Indeed, git bisect fingers that commit as introducing the problem.
>
> Is there anything I can do for this to not fade to oblivion ?
> Will a mail to pgsql-bugs help ?

Tom: I saw you pushed a fix for the interruptability with this:
https://github.com/postgres/postgres/commit/f5f21315d25ffcbfe7c6a3fa6ffaad54d31bcde0

But we also noticed a memory leak in the regepx_replace call, did you notice
that in your tests ? Same regexp as reported. Do you need another testcase ?

--strk;

()  ASCII ribbon campaign -- Keep it simple !
/\  http://strk.keybit.net/rants/ascii_mails.txt

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Fujii Masao 2014-03-18 17:16:00 Re: BUG #9118: WAL Sender does not disconnect replication clients during shutdown
Previous Message Michael Buccetti 2014-03-18 16:38:25 Re: BUG #9604: Unable to access table remotely

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2014-03-18 17:13:52 json/jsonb/hstore operator precedence
Previous Message Claudio Freire 2014-03-18 16:53:53 Re: Planner hints in Postgresql