Re: Changeset Extraction v7.9.1

Andres Freund escribió:

> fprintf(stderr,
> - _("%s: could not identify system: got %d rows and %d fields, expected %d rows and %d fields\n"),
> - progname, PQntuples(res), PQnfields(res), 1, 3);
> + _("%s: could not identify system: got %d rows and %d fields, expected 1 row and 3 or more fields\n"),
> + progname, PQntuples(res), PQnfields(res));

Please don't change this. The reason these messages use %d and an extra
printf argument is to avoid giving translators extra work when the
number of rows or fields is changed. In these cases I suggest this:

> - _("%s: could not identify system: got %d rows and %d fields, expected %d rows and %d fields\n"),
> - progname, PQntuples(res), PQnfields(res), 1, 3);
> + _("%s: could not identify system: got %d rows and %d fields, expected %d rows and %d or more fields\n"),
> + progname, PQntuples(res), PQnfields(res), 1, 3);

(Yes, I know the "expected 1 rows" output looks a bit silly. Since this
is an unexpected error message anyway, I don't think that's worth
fixing.)

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services